This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[WIP] Onnx export API optional args and additional operator support, Fixes #12682 #12946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mxnet-label-bot [ONNX, pr-work-in-progress] |
Roshrini
changed the title
[WIP] Onnx export API optional args and additional operator support
[WIP] Onnx export API optional args and additional operator support, Fixes #12682
Oct 31, 2018
@Roshrini thanks for you contribution. There appears to be build failure could you take a look? |
@Roshrini ping again to address CI and description |
vandanavk
reviewed
Nov 28, 2018
@@ -926,8 +966,14 @@ def convert_minus_scalar(node, **kwargs): | |||
""" | |||
return scalar_op_helper(node, 'Sub', **kwargs) | |||
|
|||
@mx_op.register("_rminus_scalar") | |||
def convert_rminus_scalar(node, **kwargs): | |||
"""Map MXNet's _rminus_scalar operator attributes to onnx's Minus operator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: onnx's Sub operator
Will update and create new PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ONNX export api takes optional arguments out_label and out_shapes
Adding operators - LogisticRegressionOutput, MakeLoss, BlockGrad, _rminus_scalar, r_div_scalar, identity
#12925
WIP - Need to add:
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments